fix(mavlink): harden endpoint transport lifecycle - #2164
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Consolidates the endpoint/network-layer fixes reviewed from:
agent/mavlink-runtime-hardeningfeature/mavlink-transport-lifecycle-fixesThis branch starts from current
developmentand deliberately excludes twin/state changes.Required fixes retained
finallyblockThrowablehandling/stack traces in the outbound path with bounded loggingMAVLink V1 correction
MAVLink V1 has four bytes after magic and payload length: sequence, system ID, component ID, and message ID. A complete V1 frame is therefore
payload length + 8bytes. The old serial parser and its test fixture both used a fabricated fifth header byte; both are corrected here. UDP extraction already usedpayload + 8.Tests
Deliberately excluded
MavlinkProtocolFactory, which logged but did not establish a complete cleanup contractstate/mavlinkand twin management changes (separate PR)Validation note
Focused Maven execution was attempted, but this environment cannot resolve
repository.mapsmessaging.ioor Maven Central. GitHub Actions is the authoritative test run for this draft.